update video concatenation logic

app.py

@@ -235,6 +235,10 @@ def process_final_combination(audio_in, chosen_translated, volume, cut_start, vi
     else:
         return gr.update(value=temp_output_path, visible=True), gr.update(visible=False)
 
+import tempfile
+import gradio as gr
+from moviepy.editor import VideoFileClip, AudioFileClip, ImageClip, concatenate_videoclips
+
 def replace_video_audio(video_path: str, new_audio_path: str) -> str:
     """
     Replaces a video's audio with new translated audio.
@@ -256,37 +260,48 @@ def replace_video_audio(video_path: str, new_audio_path: str) -> str:
     if not isinstance(video_path, str):
         raise ValueError(f"video_path must be a string, got {type(video_path)}")
 
-    # Load video
+    # Load video and audio
     video = VideoFileClip(video_path)
-    
-    # Load new audio
     new_audio = AudioFileClip(new_audio_path)
 
     # Extend video if new audio is longer
     if new_audio.duration > video.duration:
-        last_frame = video.get_frame(video.duration - 0.1)  # Extract last frame
-        freeze_frame = ImageClip(last_frame).set_duration(new_audio.duration - video.duration)
-        freeze_frame = freeze_frame.set_fps(video.fps)  # Maintain video frame rate
+        # Safely extract last frame
+        print("Extending video to match longer audio...")
+        last_frame = None
+        for frame in video.iter_frames():  # Iterates through all frames
+            last_frame = frame
+
+        if last_frame is None:
+            raise RuntimeError("Failed to extract last frame from video.")
+
+        freeze_duration = new_audio.duration - video.duration
+        freeze_frame = ImageClip(last_frame).set_duration(freeze_duration).set_fps(video.fps)
 
         video = concatenate_videoclips([video, freeze_frame])
 
-    # Set new audio
+    # Set the new audio track
     video = video.set_audio(new_audio)
-    
-    # Create a temp file
+
+    # Create a temp file for output
     temp_video = tempfile.NamedTemporaryFile(delete=False, suffix=".mp4")
-    
-    # Save video (explicit codec settings for MoviePy <2.0)
+
+    # Save the final video
     video.write_videofile(
         temp_video.name,
         codec="libx264",
         audio_codec="aac",
-        fps=video.fps,  # Ensure FPS is set correctly
-        preset="medium"  # Optional: Can be "slow", "medium", or "fast"
+        fps=video.fps,
+        preset="medium"
     )
 
-    
-    return gr.update(value=temp_video.name, visible=True)  # Return path to temp video file
+    # Clean up resources
+    video.close()
+    new_audio.close()
+
+    # Return path to new video
+    return gr.update(value=temp_video.name, visible=True)
+
 
 def clean_previous_video_input():
     return gr.update(value=None)